UI Team Code Review Reviewed by Grid Team

Priorities *****Major Problem ****Important Suggestion ***Normal **Less important idea *Minor idea/Code aesthetics

General Code Issues ****Keep in mind what would make the interface easier for the user, what items are most important (and should be more prominent) ***Very brief/confusing commenting in anything that's not an interface *Consider using properties when you need getters/setters. You can even have abstract properties in interfaces. *Clean up your code (empty constructors can be deleted, etc.)

MainForm ****Is there a way to abstract some of the bulk out of MainForm and into other classes? ***Maybe each pane should be its own class? And then the MainForm can just handle the arrangement on the screen. **Maybe even with an Interface for the IFileView, IGridView, IDirectConnectView, IstatusBar, IMenuBar, etc. Maybe not. **Do all methods need to be public? **Convention says that method names should capitalized. Try to keep some kind of consistent naming convention. *initializeInk has a try-catch with no catch code

Controller ****Get the simulator out of the controller ***Comment the controller ***A file should have 1 class in it. Not 5

IComputer **ILocation interface should be in its own file.

IFileSystemAdapter **IFlatFileSystemAdapter should probably be in its own file too

IView **Is the IView the view of the Grid, or the entire view of the application in general? **Shouldn't there be other notification methods to update the view?

INetworkAdapter **Why does "An interface for getting the computers in the grid" have a StartProcess method that "Runs the given file on the given computer"?

LoginInfo *Equals() - why do you check "if (o is LoginInfo" twice?

LocationInfo *You don't need properties X and Y with getters, and a getX and getY function.

Interface Problems *****If I directly connect to both machines, then select both directly connected computers, then tell it to disconnect (either by menu item or right- click menu), then it crashes beautifully. *****When you kill one machine and refresh the other, both still show up. ****The Resource status bar can be resized in really bad ways. ****We had problems using the inking, especially circling to connect.

Interface ideas ****The Jobs pane should go in its own tabbed view or auto-hide or something. Perhaps Files and Jobs should be tabs in the same left pane, and Jobs only shows the name and maybe a status icon. Then you could select a file, computer, or job and see its properties in the pane on the right. ***Maybe show more resource info in a tooltip box, or a properties pane (which could also show detailed process information later too) ***View -> Refresh. And set up a timer to do it automatically too. ***Consider having an Options Dialog in the future to set all the many options we might want the user to be able to control. **Items in Tool menu should be in a Grid menu or a Network menu, or maybe even Edit. They're key program features, not tools. *The Files tab should maybe be called "Voltron Files" or "Distributed Files" or something to show that it's not just showing local files. *What is the title? "b:1" is this the node name? Why is it the same for both? Only Adam saw this title (old version?)

Local Node ***How do we know which node is the local node? ***Why can you directly connect to your local node? Still unsure about this. Or maybe you should start off directly connected to your own computer

Blob View and Location ***What is the point of showing just 1 node's location on the blob view? ***Why is the displayed location different from where I clicked? (a little bit down) ***What is the purpose of knowing the location? The map blob view seems pretty meaningless.

Interface Startup ***Is this always going to be a console app? **Why does it take 15 seconds to initialiSe the network topology? *Console: "Initialising" should be "Initializing"

Future Interface Ideas You will need to be able to upload local files to the file system You will need to be able to upload local files to the file system Also start thinking about how to let the user specify a workflow to run on the grid Also start thinking about how to let the user specify a workflow to run on the grid And there's all kinds of fun administration stuff you'll have to do eventually: quotas, user management, etc. And there's all kinds of fun administration stuff you'll have to do eventually: quotas, user management, etc.